Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic highlight and document symbols on slang 0.10 #523

Merged
merged 18 commits into from
Jan 9, 2024
Merged

Semantic highlight and document symbols on slang 0.10 #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d8e6fdf
feat: semantic highlighting
antico5 May 2, 2023
6db7e3d
feat: documentSymbol - project outline
antico5 May 23, 2023
59d1055
chore: migrate to slang 0.10.1
antico5 Oct 24, 2023
2305c70
track performance spans
antico5 Oct 27, 2023
5bd248d
error tolerance for document symbols
antico5 Oct 27, 2023
2677dbc
decouple onSemanticTokens from solidity-parser
antico5 Oct 27, 2023
fea4b12
optimize walking by storing references
antico5 Oct 30, 2023
4fe2396
leverage trackTimingSync error handling
antico5 Oct 30, 2023
2d9db70
enable documentSymbol and semanticHighlight only on slang-supported p…
antico5 Oct 30, 2023
efed2df
feature flags
antico5 Nov 2, 2023
6a8dd2c
use finders for walking the cst
antico5 Nov 2, 2023
d995a5d
rework semantic highlighting to use cursor finders
antico5 Nov 11, 2023
c5dcf84
fix linter
antico5 Nov 11, 2023
a357352
Changes based on PR feedback (part 1)
antico5 Dec 8, 2023
f3095bd
Support unnamed function definition on documentSymbols
antico5 Dec 8, 2023
6d58175
refactor based on feedback
antico5 Dec 16, 2023
ea7fa83
moving version selection to slangHelpers
antico5 Jan 6, 2024
76b210f
add comment to semantic tokens test
antico5 Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions client/scripts/bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ async function main() {
external: [
"vscode",
"@nomicfoundation/solidity-analyzer",
"@nomicfoundation/slang",
"fsevents",
"mocha",
],
Expand Down Expand Up @@ -198,6 +199,17 @@ async function main() {
"@nomicfoundation/solidity-analyzer-linux-x64-gnu": "0.1.1",
"@nomicfoundation/solidity-analyzer-linux-x64-musl": "0.1.1",
"@nomicfoundation/solidity-analyzer-freebsd-x64": "0.1.1",

OmarTawfik marked this conversation as resolved.
Show resolved Hide resolved
"@nomicfoundation/slang": "0.10.1",
"@nomicfoundation/slang-darwin-arm64": "0.10.1",
"@nomicfoundation/slang-win32-arm64-msvc": "0.10.1",
"@nomicfoundation/slang-linux-arm64-gnu": "0.10.1",
"@nomicfoundation/slang-linux-arm64-musl": "0.10.1",
"@nomicfoundation/slang-win32-ia32-msvc": "0.10.1",
"@nomicfoundation/slang-darwin-x64": "0.10.1",
"@nomicfoundation/slang-win32-x64-msvc": "0.10.1",
"@nomicfoundation/slang-linux-x64-gnu": "0.10.1",
"@nomicfoundation/slang-linux-x64-musl": "0.10.1",
},
})
);
Expand Down
9 changes: 9 additions & 0 deletions flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"documentSymbol": {
OmarTawfik marked this conversation as resolved.
Show resolved Hide resolved
"percent": 0
},

"semanticHighlighting": {
"percent": 0
}
}
227 changes: 226 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"url": "https://github.com/NomicFoundation/hardhat-vscode/issues"
},
OmarTawfik marked this conversation as resolved.
Show resolved Hide resolved
"scripts": {
OmarTawfik marked this conversation as resolved.
Show resolved Hide resolved
"postinstall": "npm install --no-save --ignore-scripts --force @nomicfoundation/solidity-analyzer-win32-ia32-msvc@0.1.1",
"build": "tsc -b ./client/tsconfig.json && tsc -b ./server/tsconfig.build.json && tsc -b ./coc/tsconfig.json && tsc -b",
"watch": "concurrently -n client,server \"tsc -b -w ./client/tsconfig.json\" \"tsc -b -w ./server/tsconfig.build.json\"",
"test:unit": "npm -w server run test",
Expand Down
3 changes: 2 additions & 1 deletion server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"@types/qs": "^6.9.7",
"@types/semver": "^7.3.12",
"@types/sinon": "10.0.6",
"@types/yaml": "^1.9.7",
"c3-linearization": "0.3.0",
"chai": "4.3.4",
"codecov": "3.8.3",
Expand Down Expand Up @@ -84,10 +85,10 @@
"vscode-languageserver-textdocument": "1.0.8",
"vscode-languageserver-types": "3.17.3",
"vscode-uri": "3.0.7",
"@types/yaml": "^1.9.7",
"yaml": "^2.2.1"
},
"dependencies": {
"@nomicfoundation/slang": "^0.10.1",
"@nomicfoundation/solidity-analyzer": "0.1.1"
}
}
7 changes: 6 additions & 1 deletion server/scripts/bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,12 @@ async function main() {
minifyWhitespace: true,
minifyIdentifiers: false,
minifySyntax: true,
external: ["@nomicfoundation/solidity-analyzer", "fsevents", "mocha"],
external: [
"@nomicfoundation/solidity-analyzer",
"@nomicfoundation/slang",
"fsevents",
"mocha",
],
platform: "node",
outdir: ".",
logLevel: "info",
Expand Down
Loading