Upgrade to Slang 0.13.1 #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ranges for variable statement changed because the CST shape changed, which affects the ranges in the test snapshots.
This introduced support for EVM built-ins, so this should substantially increase correct parse coverage.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/slang@0.10.1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## development #545 +/- ##
==============================================
Coverage ? 52.61%
==============================================
Files ? 228
Lines ? 5318
Branches ? 835
==============================================
Hits ? 2798
Misses ? 2282
Partials ? 238 ☔ View full report in Codecov by Sentry. |
OmarTawfik
reviewed
Feb 22, 2024
OmarTawfik
reviewed
Feb 22, 2024
OmarTawfik
reviewed
Feb 22, 2024
OmarTawfik
reviewed
Feb 22, 2024
OmarTawfik
reviewed
Feb 22, 2024
server/src/services/semanticHighlight/highlighters/FunctionDefinitionHighlighter.ts
Show resolved
Hide resolved
OmarTawfik
reviewed
Feb 22, 2024
server/src/services/semanticHighlight/highlighters/ContractDefinitionHighlighter.ts
Show resolved
Hide resolved
OmarTawfik
reviewed
Feb 22, 2024
OmarTawfik
approved these changes
Feb 22, 2024
OmarTawfik
reviewed
Feb 22, 2024
This aims to retain the existing behaviour. We should improve and enhance the behaviour but probably using queries instead, otherwise this will involve a bit of manual node selection and rules that can change fairly often.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to focus on the upgrading the version with the least amount of changes to facilitate the review.
One change that I introduced is that I introduced CST node name checks in the
SymbolVisitorto better convey which node we want to match, e.g.namenode in the StateVariableDeclaration (instead of a possible second identifier in the= ...init part). Some CST node ranges were changed, so I had to modify the snapshot data.Next step should probably include migrating to queries for both perf and completeness' sake (i.e.
FunctionDefinition>FunctionNamethat can be eitherIdentifieror a keyword).It's worth noting that this version correctly parses contextual keywords (like
from) and supports parsing EVM built-ins, so it should parse correctly a lot more code than the previous 0.10 version.Part of NomicFoundation/slang#639