Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that ethers doesn't use Hardhat Network's config values for gas, gasPrice, gasMultiplier #2406

Merged
merged 4 commits into from
May 5, 2022
Merged

Document that ethers doesn't use Hardhat Network's config values for gas, gasPrice, gasMultiplier #2406

merged 4 commits into from
May 5, 2022

Conversation

feuGeneA
Copy link
Contributor

No description provided.

@feuGeneA feuGeneA self-assigned this Feb 21, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 71d1636

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

fvictorio
fvictorio approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but LGTM.

@feuGeneA @fvictorio
"Note that when" not "Note when when"
67f0a1c 
Co-authored-by: Franco Victorio <victorio.franco@gmail.com>
@alcuadrado
Copy link
Member

I think we should add a section explaining this to the ethers plugin's readme

@feuGeneA @fvictorio
add link to ethers overrides
71d1636 
Co-authored-by: Franco Victorio <victorio.franco@gmail.com>
@fvictorio fvictorio mentioned this pull request Mar 15, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

This PR was marked as stale because it didn't have any activity in the last 30 days. Please excuse us if we didn't have enough time to review it and get it merged. If you are still interested in getting these changes applied, please leave a comment indicating so. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 5, 2022
@feuGeneA feuGeneA merged commit 07c7f68 into master May 5, 2022
@feuGeneA feuGeneA deleted the doc-node-gas-cfg-not-for-ethers branch May 5, 2022 13:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio approved these changes

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees

@feuGeneA feuGeneA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feuGeneA @alcuadrado @fvictorio