Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement fork state management #3612

Merged
merged 84 commits into from
May 4, 2023
Merged

feat: implement fork state management #3612

merged 84 commits into from
May 4, 2023

Conversation

feuGeneA
Copy link
Contributor

@feuGeneA feuGeneA commented Jan 25, 2023 •
edited by Wodann
Loading

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ff60f36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 6:48pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 6:48pm

@feuGeneA feuGeneA force-pushed the rethnet/30-implement-napi-bindings-for-forkeddatabase branch from 1871161 to 0ff3a11 Compare February 10, 2023 01:41
@feuGeneA feuGeneA mentioned this pull request Feb 10, 2023
Merged
1 task
@feuGeneA feuGeneA force-pushed the rethnet/30-implement-napi-bindings-for-forkeddatabase branch from 0ff3a11 to c69e6ff Compare February 14, 2023 06:35
@feuGeneA feuGeneA force-pushed the rethnet/30-implement-napi-bindings-for-forkeddatabase branch from c69e6ff to d759483 Compare February 14, 2023 06:45
@feuGeneA feuGeneA force-pushed the rethnet/30-implement-napi-bindings-for-forkeddatabase branch from f8192d6 to 2c28287 Compare February 16, 2023 18:57
@feuGeneA feuGeneA force-pushed the rethnet/30-implement-napi-bindings-for-forkeddatabase branch from 2c28287 to 829e3c7 Compare February 17, 2023 05:11
@Wodann
misc: remove test-with dependency
b74f390 
To disable remote tests - that depend on ALCHEMY_URL - use the
`test-disable-remote` feature flag instead
@Wodann Wodann requested review from Wodann and removed request for Wodann May 3, 2023 16:55
@Wodann
Copy link
Member

Wodann commented May 3, 2023

I addressed all outstanding comments and resolved merge conflicts.

The only way to get rid of my original "suggestions requested" status was to change it into approved. Waiting for others to finalise any additional comments before merging

feuGeneA
feuGeneA commented May 3, 2023
View reviewed changes
.github/workflows/hardhat-core-ci.yml Outdated Show resolved Hide resolved
crates/rethnet_evm/src/state/fork.rs Outdated Show resolved Hide resolved
crates/rethnet_eth/src/remote/client.rs Outdated Show resolved Hide resolved
crates/rethnet_eth/src/remote/client.rs Outdated Show resolved Hide resolved
crates/rethnet_eth/src/remote/client.rs Outdated Show resolved Hide resolved
crates/rethnet_eth/src/remote/client.rs Outdated Show resolved Hide resolved
crates/rethnet_eth/src/remote/client.rs Show resolved Hide resolved
@Wodann Wodann force-pushed the rethnet/30-implement-napi-bindings-for-forkeddatabase branch from d9d554a to bedf50c Compare May 3, 2023 19:09
@Wodann Wodann merged commit 43e8572 into rethnet/main May 4, 2023
@Wodann Wodann deleted the rethnet/30-implement-napi-bindings-for-forkeddatabase branch May 4, 2023 18:51
@Wodann Wodann linked an issue May 4, 2023 that may be closed by this pull request
Implement fork state management NomicFoundation/edr#9
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

@fvictorio fvictorio fvictorio left review comments

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees

@Wodann Wodann

@feuGeneA feuGeneA

Labels
area:edr
Projects
Hardhat
Archived in project
Milestone
No milestone
4 participants
@feuGeneA @Wodann @fvictorio @alcuadrado