Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: explicitly make snapshots in block builder #3810

Merged
merged 3 commits into from
Apr 11, 2023
Merged

refactor: explicitly make snapshots in block builder #3810

merged 3 commits into from
Apr 11, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Apr 3, 2023

No description provided.

@Wodann Wodann requested a review from fvictorio April 3, 2023 23:30
@Wodann Wodann self-assigned this Apr 3, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7fd50c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 3:14pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 3:14pm

@Wodann Wodann changed the title refactor: simplify set_state_root by using make_snapshot in hardhat refactor: explicitly make snapshots in block builder Apr 11, 2023
@Wodann Wodann merged commit e5a03d9 into rethnet/main Apr 11, 2023
@Wodann Wodann deleted the feat/snapshot branch April 11, 2023 15:44
@Wodann Wodann linked an issue Apr 12, 2023 that may be closed by this pull request
Optimise Rethnet to match EthereumJS runtime performance NomicFoundation/edr#66
Closed
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio approved these changes

Assignees

@Wodann Wodann

Labels
status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise Rethnet to match EthereumJS runtime performance
2 participants
@Wodann @fvictorio