feat: assorted synthetic benchmarks for SyncState

[feuGeneA]

Fixes NomicFoundation/edr#71

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2415c08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2023 6:09pm
hardhat-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2023 6:09pm

[Wodann]

Could you please move all of the local use statements to the top of the file. There is no benefit in Rust to have them locally, in this case.

Use cases where it would be helpful is:

• if you have conflicting naming; or
• if you are including use statement in a scope that's behind a feature flag, as you'd also need to put the use statement itself behind the feature flag if you do it at the top of the file.

[feuGeneA]

I'm sorry I've been stubborn about this, and I realize that there is no benefit in Rust, but as a reader of the code I actually find it immensely beneficial. Given that such imported traits have no direct mention in the file, I appreciate having their placement restricted to the scope they're actually needed in. If that scope is the entire file, due to repeated uses within the file, then at the top of the file is the right place. But if the use is only in a single inner scope, then I feel that the placement should be within that single inner scope. (Note that in this particular case I do have a repetition of revm::db::State within this file, but that's because I expect one of those usages to go away depending on which version of that function we end up keeping.)

[Wodann]

A language server provides you that information if you need a reminder though

[feuGeneA]

true, but what if for example i'm just browsing the code on github? etc. maybe i'm being overly principled, but it doesn't seem right to depend on tooling for readability. in my latest draft all of the use are at the top, by virtue of using SyncState, so it's a moot point for this PR, but this does remain one of the (very) few smelly things in my limited Rust experience.

[Wodann]

GitHub these days also offers redirects to type definitions. It seems like you're trying to tailor to a niche while cluttering the code with unnecessary noise for the majority of use cases.