Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in benchmark of StateRef::basic() #3886

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

feuGeneA
Copy link
Contributor

It wasn't even doing anything at all!

It wasn't even doing anything at all!
@feuGeneA feuGeneA requested a review from Wodann April 26, 2023 22:09
@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

⚠️ No Changeset found

Latest commit: 033d1c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 10:09pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 10:09pm

@Wodann Wodann changed the title Fix bug in benchmark of StateRef::basic() fix: bug in benchmark of StateRef::basic() Apr 26, 2023
@Wodann Wodann merged commit b7e7634 into rethnet/main Apr 26, 2023
@Wodann Wodann deleted the rethnet/fix-bug-in-bench-basic branch April 26, 2023 22:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants