Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store code when inserting account in LayeredState #3887

Merged
merged 6 commits into from
May 3, 2023
Merged

fix: store code when inserting account in LayeredState #3887

merged 6 commits into from
May 3, 2023

Conversation

feuGeneA
Copy link
Contributor

No description provided.

@feuGeneA feuGeneA requested a review from Wodann April 26, 2023 22:19
@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 74f7877

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 9:46pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 9:46pm

@feuGeneA feuGeneA marked this pull request as ready for review April 27, 2023 23:45
Wodann
Wodann requested changes Apr 28, 2023
View reviewed changes
crates/rethnet_evm/src/state/layered/changes.rs Outdated Show resolved Hide resolved
crates/rethnet_evm/src/state/layered.rs Outdated Show resolved Hide resolved
crates/rethnet_evm/src/state/hybrid.rs Outdated Show resolved Hide resolved
crates/rethnet_evm/src/state/layered.rs Outdated Show resolved Hide resolved
@Wodann Wodann changed the title Add unit test of LayeredState::code_by_hash() fix: split code when inserting account in LayeredState Apr 28, 2023
@Wodann Wodann changed the title fix: split code when inserting account in LayeredState fix: store code when inserting account in LayeredState Apr 28, 2023
@feuGeneA @Wodann
U256::ZERO, not U256::from(0)
9658336 
Co-authored-by: Wodann <Wodann@users.noreply.github.com>
@feuGeneA @Wodann
Apply suggestions from code review
74f7877 
Co-authored-by: Wodann <Wodann@users.noreply.github.com>
@feuGeneA feuGeneA requested a review from Wodann May 2, 2023 22:31
@Wodann Wodann merged commit bd570ca into rethnet/main May 3, 2023
@Wodann Wodann deleted the rethnet/test-code-by-hash branch May 3, 2023 03:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees
No one assigned
Labels
status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feuGeneA @Wodann