Add a better mechanism for variables management #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2257ae6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fvictorio
reviewed
Oct 10, 2023
packages/hardhat-core/test/internal/core/secrets/secrets-manager.ts
Outdated
Show resolved
Hide resolved
fvictorio
reviewed
Nov 1, 2023
Comment on lines
+130
to
+133
| const globalAsAny: any = global; | ||
| Object.entries(configEnv).forEach( | ||
| ([key, value]) => (globalAsAny[key] = value) | ||
| ); |
There was a problem hiding this comment.
The comment should also indicate that this is a lightweight version of loadConfigAndTasks that duplicates some of its logic. @schaable this is a decision we consciously made; the alternative was to refactor the config-loading.ts module to make that part of the logic reusable, but that didn't seem worth the risk.
fvictorio
reviewed
Nov 1, 2023
fvictorio
approved these changes
Nov 2, 2023
fvictorio
deleted the
feature/2265-add-a-better-mechanism-for-secrets-management
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new feature: configuration variables.
See docs for more info: https://hardhat.org/hardhat-runner/docs/guides/configuration-variables