Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EDR build on Windows ARM #4475

Merged
merged 14 commits into from
Oct 13, 2023
Merged

fix: EDR build on Windows ARM #4475

merged 14 commits into from
Oct 13, 2023

Conversation

agostbiro
Copy link
Member

@agostbiro agostbiro commented Oct 13, 2023 •
edited
Loading

Supersedes #4465 as that one got screwed up after changing the base branch. There are three differences in this PR:

  • I merged hardhat-edr-merge to the branch.
  • The base branch is hardhat-edr-merge
  • I cherry picked 02a1e90 to resolve hardhat-viem CI failing due to EDR requiring >= Node 18.

No OOM failures in this PR for the hardhat-core CI jobs: https://github.com/NomicFoundation/hardhat/actions/runs/6510101301?pr=4475

@agostbiro agostbiro self-assigned this Oct 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b97c992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 5:12pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 5:12pm

@agostbiro agostbiro marked this pull request as draft October 13, 2023 15:17
@agostbiro agostbiro changed the title fix: use k256 CI test fix: EDR build on Windows ARM (2) Oct 13, 2023
@agostbiro agostbiro marked this pull request as ready for review October 13, 2023 16:39
@agostbiro agostbiro requested a review from Wodann October 13, 2023 16:40
@agostbiro agostbiro mentioned this pull request Oct 13, 2023
Closed
This was linked to issues Oct 13, 2023
Support aarch64-pc-windows-msvc in the EDR JS package NomicFoundation/edr#200
Closed
Switch from secp256k1 to k256 NomicFoundation/edr#199
Closed
@agostbiro
Merge branch 'hardhat-edr-merge' into edr/fix/k256-test-ci
b97c992 
# Conflicts:
#	Cargo.lock
#	crates/rethnet_evm/Cargo.toml
Base automatically changed from hardhat-edr-merge to rethnet/main October 13, 2023 18:11
@Wodann Wodann changed the title fix: EDR build on Windows ARM (2) fix: EDR build on Windows ARM Oct 13, 2023
@Wodann Wodann merged commit 94cb2d5 into rethnet/main Oct 13, 2023
94 of 97 checks passed
@Wodann Wodann deleted the edr/fix/k256-test-ci branch October 13, 2023 18:15
This was referenced Oct 16, 2023
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Wodann Wodann Wodann approved these changes

Assignees

@agostbiro agostbiro

Labels
area:edr
Projects
EDR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aarch64-pc-windows-msvc in the EDR JS package Switch from secp256k1 to k256
2 participants
@agostbiro @Wodann