Fix compiler download #4502
Merged
Fix compiler download #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler downloader was broken because it was trying to write an ArrayBuffer to a file. This commit fixes it by converting the ArrayBuffer to a Buffer before writing it to the file. This was working before because undici was returning a Uint8Array under the hood, but this was fixed in the latest version.
🦋 Changeset detectedLatest commit: abca5ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ChristopherDedominici
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler downloader was broken because it was trying to write an
ArrayBufferto a file. This PR fixes it by converting theArrayBufferto aBufferbefore writing it to the file.This was working before because undici was returning a
Uint8Arrayunder the hood, but this was fixed in the latest version.