Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize input addresses to lowercase for comparison #4529

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

schaable
Copy link
Member

Normalized user-input addresses from CLI and libraries file for correct comparison.

@schaable schaable self-assigned this Oct 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

🦋 Changeset detected

Latest commit: c7d87c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/hardhat-verify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview Oct 25, 2023 4:06pm
hardhat-storybook ✅ Ready (Inspect) Visit Preview Oct 25, 2023 4:06pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 25, 2023
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a minor: is there a test to cover this scenario?

@fvictorio
Copy link
Member

I'm ok with merging this without a test, since doing a proper test for this is going to be super involved, and these are very low-risk changes.

@schaable schaable merged commit 6dc76a5 into main Nov 3, 2023
@schaable schaable deleted the sourcify-is-verified-bug branch November 3, 2023 14:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants