Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove async-trait #4590

Merged
merged 2 commits into from
Nov 17, 2023
Merged

refactor: remove async-trait #4590

merged 2 commits into from
Nov 17, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Nov 16, 2023

No description provided.

@Wodann Wodann requested a review from agostbiro November 16, 2023 10:55
@Wodann Wodann self-assigned this Nov 16, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 43a158d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 4:27am

@Wodann Wodann linked an issue Nov 16, 2023 that may be closed by this pull request
Remove async traits to prevent exposing of async fn NomicFoundation/edr#237
Closed
agostbiro
agostbiro requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM overall, just the JS lint needs to be fixed + had some questions.

crates/edr_evm/tests/blockchain.rs Show resolved Hide resolved
crates/edr_napi/src/block/builder.rs Show resolved Hide resolved
@Wodann Wodann requested a review from agostbiro November 17, 2023 04:26
@agostbiro agostbiro merged commit 6d752a1 into edr/main Nov 17, 2023
102 checks passed
@agostbiro agostbiro deleted the edr/refactor/async-trait branch November 17, 2023 13:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

Assignees

@Wodann Wodann

Labels
area:edr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove async traits to prevent exposing of async fn
2 participants
@Wodann @agostbiro