feat: add hardhat config RPC methods #4596
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -118,7 +119,7 @@ pub enum Request { | |||
| serialize_with = "single_to_sequence", | |||
| deserialize_with = "sequence_to_single" | |||
| )] | |||
| SetPrevRandao(ZeroXPrefixedBytes), | |||
| SetPrevRandao(B256), | |||
There was a problem hiding this comment.
Just double checking: does B256 serializes into 0x... string?
| ) -> Result<bool, ProviderError> { | ||
| let spec_id = data.spec_id(); | ||
| if spec_id < SpecId::LONDON { | ||
| return Err(ProviderError::UnmetHardfork { |
There was a problem hiding this comment.
Wondering if this is going to match error returned by Hardhat. Is that a concern at all @alcuadrado @fvictorio ?
| /// The number of the block that the network forked from. | ||
| pub fork_block_number: u64, | ||
| /// The hash of the block that the network forked from. | ||
| pub fork_block_hash: B256, |
There was a problem hiding this comment.
Noticed that the Hardhat type doesn't explicit say that this is a 0x-prefixed string. Are we sure it is?
// The hash of the block that the network forked from.
forkBlockHash: string;
There was a problem hiding this comment.
const latestBlockHashHex = latestBlock.header.hash().toString("hex");
const latestBlockHash = `0x${latestBlockHashHex}`;
Wodann
force-pushed
the
edr/feat/rpc-config
branch
from
a88a7d2 to
d07025d
Compare
Wodann
force-pushed
the
edr/feat/rpc-config
branch
from
d07025d to
3fa4a72
Compare
As part of this change, I made the
network_idau64as there was no need for it to support up toU256. It's represented as a string decimal in the JSON-RPC. TheU64allows deserialization of these values too, making it a convenient helper.