feat: port filters to EDR provider #4747

Wodann · 2024-01-09T20:45:23Z

No description provided.

…nsaction

changeset-bot · 2024-01-09T20:45:28Z

⚠️ No Changeset found

Latest commit: 10606d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-01-09T20:45:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 11, 2024 8:08pm

agostbiro

Thanks, Rust part LGTM! There is just one small thing that we could potentially improve where I left a comment, but feel free to merge without it as it was there prior.

agostbiro · 2024-01-11T10:42:07Z

crates/edr_eth/src/remote/cacheable_method_invocation.rs

+            CacheableLogFilterRange::Hash(_) => Some(Self::finalize(hasher)),
+            CacheableLogFilterRange::Range { to_block, .. } => {
+                // TODO should we check that to < from?
+                Self::needs_safety_check(hasher, to_block)


I'm not sure what's the expected behavior if to < from, but to be safe, we could potentially check the safety of the max of to and from. Wdyt?

For Alchemy, if to < from, you get this error:

{"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"One of the blocks specified in filter (fromBlock, toBlock or blockHash) cannot be found."}}

so using the maximum of those two wouldn't resolve the issue, I think. We might just have to prohibit caching if this occurs?

agostbiro · 2024-01-11T11:19:32Z

Sorry, one more thing: I think the websocket tests should be passing now as well, could you try to enable them and fix any potential issues?

packages/hardhat-core/src/internal/hardhat-network/provider/provider.ts

Wodann · 2024-01-11T20:05:16Z

Sorry, one more thing: I think the websocket tests should be passing now as well, could you try to enable them and fix any potential issues?

The "plain websocket" tests indeed work now, but the ethers.WebSocketProvider tests don't yet. I'll leave this for a separate task, if you don't mind.

@fvictorio can you shine some light on how we'd want to implement ethers.WebSocketProvider in this case?

Wodann added 30 commits December 29, 2023 18:44

fix: lets you impresonate a contract

92907b0

fix: hardhat_reset

d5ba6fc

feat: add evm_setIntervalMining

c03615a

fix: hardhat_setNonce

e871ec1

fix: hardhat_setStorageAt

3a03658

WIP: test: enable hardhat module tests

e6c3877

feat: implement hardhat_dropTransaction

f4efdd0

feat: implement hardhat_mine

eb3df92

fix: hash collision tests

2492fde

fix: block timestamp offset

e1a76a1

fix: hardhat_setNextBlockBaseFeePerGas when EIP-1559 is disabled

a8df316

fix: hardhat_setPrevRandao in hardforks before the merge

8f54479

fix: hardhat_metadata for local blockchain

8af1667

fix: invalid address in JSON request

f5d8189

fix: non-numeric balance for hardhat_setBalance

1cd94da

fix: invalid data argument for hardhat_setCode

09b82da

fix: non-numeric nonce for hardhat_setNonce

c9c70be

fix: non-numeric storage key for hardhat_setStorageAt

0a3233d

fix: invalid argument errors in hardhat_*

d1e922e

Merge remote-tracking branch 'origin/edr/main' into edr/feat/drop-tra…

020ed07

…nsaction

fix: impersonate account RPC requests

867b800

fix: Hardhat error message for hardhat_setStorageAt

052ebe8

fix: hash collission tests

52a610d

fix: return correct error code

c0db3d4

fix: rounding error in initial block time offset

255ea24

fix: linter

f7bd30e

fix: negative elapsed time for block offset

cd3ca9c

test: enable and fix forked-provider tests

1c0e8ce

test: enable and fix forked-provider tests

37826b3

feat: add eth_mining and eth_syncing

7c13a35

Wodann added the area:edr label Jan 9, 2024

Wodann self-assigned this Jan 9, 2024

github-actions bot added the status:triaging label Jan 9, 2024

Merge remote-tracking branch 'origin/edr/main' into edr/feat/filters

c9b6e7f

Wodann changed the title ~~Edr/feat/filters~~ feat: port filters to EDR provider Jan 9, 2024

vercel bot deployed to Preview January 9, 2024 20:49 View deployment

Wodann added 2 commits January 9, 2024 22:22

feat: port eth_getLogs

32b0076

fix: no-default-features

745bf6e

vercel bot deployed to Preview January 9, 2024 22:32 View deployment

WIP: subscribe

cb280f9

vercel bot deployed to Preview January 10, 2024 00:06 View deployment

fix: eth_subscribe

16e0d69

Wodann removed the status:triaging label Jan 10, 2024

vercel bot deployed to Preview January 10, 2024 19:30 View deployment

Wodann marked this pull request as ready for review January 10, 2024 19:59

Wodann requested a review from agostbiro January 10, 2024 19:59

Merge remote-tracking branch 'origin/edr/main' into edr/feat/filters

17580ca

vercel bot deployed to Preview January 10, 2024 21:27 View deployment

agostbiro approved these changes Jan 11, 2024

View reviewed changes

fvictorio approved these changes Jan 11, 2024

View reviewed changes

packages/hardhat-core/src/internal/hardhat-network/provider/provider.ts Outdated Show resolved Hide resolved

doc: update comment

10606d8

Wodann merged commit e1fbd84 into edr/main Jan 11, 2024
67 of 70 checks passed

Wodann deleted the edr/feat/filters branch January 11, 2024 20:07

vercel bot deployed to Preview January 11, 2024 20:08 View deployment

Wodann linked an issue Jan 12, 2024 that may be closed by this pull request

Port Hardhat Node filters NomicFoundation/edr#114

Closed

5 tasks

github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: port filters to EDR provider #4747

feat: port filters to EDR provider #4747

Wodann commented Jan 9, 2024

changeset-bot bot commented Jan 9, 2024 •

edited

Loading

vercel bot commented Jan 9, 2024 •

edited

Loading

agostbiro left a comment

agostbiro Jan 11, 2024

Wodann Jan 11, 2024

agostbiro commented Jan 11, 2024

Wodann commented Jan 11, 2024

feat: port filters to EDR provider #4747

feat: port filters to EDR provider #4747

Conversation

Wodann commented Jan 9, 2024

changeset-bot bot commented Jan 9, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Jan 9, 2024 • edited Loading

agostbiro left a comment

Choose a reason for hiding this comment

agostbiro Jan 11, 2024

Choose a reason for hiding this comment

Wodann Jan 11, 2024

Choose a reason for hiding this comment

agostbiro commented Jan 11, 2024

Wodann commented Jan 11, 2024

changeset-bot bot commented Jan 9, 2024 •

edited

Loading

vercel bot commented Jan 9, 2024 •

edited

Loading