-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds logic for forcing through verification when is verified check fails #5504
Conversation
🦋 Changeset detectedLatest commit: 2f8ec7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
before this fix:
after this fix:
|
Agreed. I think this is a reasonable exception. Thanks for the PR! |
Looks great. Thank you! |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Hardhat Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
There is a bug in blockscout's latest releases. It has been around for quite a while. Unfortunately it only happens in certain situations. The issue is that an
isVerified
check will fail if the backend is put into a certain state. The easy way around this would simply be to include that set of errors / states to be ignored when provided a force flag.I do not think that hardhat verify should cover all of the quirks of the many backends that are bound to emerge into eternity, however, I think that the force flag being more comprehensive (less narrowly applied) than it currently is could be a reasonable middle ground, provided that it does not run afoul of any eip's.