Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(v2): parameterise v2 packages ci to minimise duplication #5565

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 1, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR is a subset of #5301.

This PR extends the approach introduced in #5564 onto the v2 packages. This minimises the duplication and makes future updates that should affect all package builds easier.

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 180994f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:08pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 1, 2024
@galargh galargh changed the title Galargh/GitHub actions deduplication ci: parameterise v2 packages ci to minimise duplication Aug 1, 2024
@galargh galargh force-pushed the galargh/github-actions-deduplication branch from 143a302 to 0128004 Compare August 1, 2024 14:48
@galargh galargh force-pushed the galargh/github-actions-deduplication branch 2 times, most recently from 471a133 to befd83d Compare August 1, 2024 14:53
@galargh galargh force-pushed the galargh/github-actions-laziness branch from 7f164e9 to 0cc2836 Compare August 2, 2024 11:24
@galargh galargh changed the title ci: parameterise v2 packages ci to minimise duplication ci: parameterise v2 packages ci to minimise duplication (v2) Aug 2, 2024
@galargh galargh force-pushed the galargh/github-actions-deduplication branch from befd83d to d9b00f6 Compare August 2, 2024 11:26
@galargh galargh changed the base branch from galargh/github-actions-laziness to main August 2, 2024 11:26
@galargh galargh changed the title ci: parameterise v2 packages ci to minimise duplication (v2) ci(v2): parameterise v2 packages ci to minimise duplication Aug 2, 2024
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 2, 2024
@galargh galargh closed this Aug 2, 2024
@galargh galargh reopened this Aug 2, 2024
@galargh galargh requested a review from alcuadrado August 2, 2024 11:56
@galargh galargh marked this pull request as ready for review August 2, 2024 11:56
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change to the lockfile should trigger everything here too

@galargh
Copy link
Member Author

galargh commented Aug 2, 2024

I added pnpm lockfile handling in 180994f

@galargh galargh requested a review from alcuadrado August 2, 2024 16:15
@galargh galargh merged commit 83721d9 into main Aug 5, 2024
96 checks passed
@galargh galargh deleted the galargh/github-actions-deduplication branch August 5, 2024 09:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants