feat: port the Http Provider to v3 #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
alcuadrado
approved these changes
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
alcuadrado
reviewed
Aug 13, 2024
- Created a Dispatcher type alias for UndiciT.Dispatcher. - This change ensures that Undici types are not directly exposed in getDispatcher. - In the future, we may narrow down the Dispatcher type to include only the required properties.
- Copied the getHardhatVersion helper from the hardhat package to the core package. - Added a caching mechanism to store the hardhat version once obtained, improving performance. - The future structure of the packages is still uncertain: we might have two different packages each with its own version, different packages with mirrored versions, or a single combined package for core and hardhat. - Currently, the helper is duplicated, which may be sufficient for now but might need to be revisited in the future.
- Added ConnectionRefusedError handling for ECONNREFUSED errors. - Added RequestTimeoutError handling for UND_ERR_CONNECT_TIMEOUT, UND_ERR_HEADERS_TIMEOUT, and UND_ERR_BODY_TIMEOUT errors.
…tDispatcher - Added getTestDispatcher function to obtain a MockAgent from undici. - Refactored test code to use a new helper function initializeTestDispatcher, which sets up the test dispatcher and returns an interceptor. - Renamed mockPool to interceptor in the test file for clarity.
- Introduced a new error type ResponseStatusCodeError to handle 4xx and 5xx HTTP response status codes. This is needed because we set throwOnError to true in all requests. - ResponseStatusCodeError includes `statusCode`, `headers`, and `body` properties.
- Ported existing HTTP provider functionality to v-next. - Updated code to support ESM, follow modern TypeScript practices, and use hardhat-utils. - Added tests for request and sendBatch.
… tests - Moved error handling logic to a handleError function to avoid code duplication. - Updated the error handling to correctly check for e.cause.code or e.code existence. - Fixed tests that were not previously updated to expect ResponseStatusCodeError.
- Added send and sendAsync from the backwards compatibility provider as we're no longer going to use wrappers. - Added jsdoc for the public methods. - Changed the HttpProvider.create signature to receive a config object. timeout is no longer optional in this object. - Default the params to an empty array if not provided. - Renamed delay to sleep. - Do not set error.data on failed retry.
schaable
force-pushed
the
http-provider
branch
from
0091a89 to
7229bd0
Compare
alcuadrado
approved these changes
Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5549
The PR includes all the changes required for porting the
HttpProviderand tests for therequestandsendBatchmethods. The PR is quite large, but it can be reviewed commit by commit. Each commit includes a description of the changes made.