Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable merge queue on the v-next branch #5596

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 13, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR adds aggregation jobs for the ci matrix jobs and lint matrix jobs on the v-next branch. This is a prerequisite to enabling required checks on the v-next branch, which in itself is a prerequisite to enabling merge queue.

TODO (after the merge):

  1. Create v-next protection rule set (assuming we don't have existing rule set nor branch protection rule yet)
    1. Go to https://github.com/NomicFoundation/hardhat/settings/rules/new?target=branch&enforcement=disabled
    2. Set the Ruleset Name
    3. Change the Enforcement status to Active
    4. Scroll to Targets > Target branches
    5. Add target > Include pattern > v-next > Add Inclusion pattern
    6. Scroll to Rules > Branch rules
    7. Check Require merge queue
    8. Check Require a pull request before merging (?)
    9. Check Require status checks to pass
      1. Add check > ci
      2. Add check > lint

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 5:40pm

Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: e460231

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 13, 2024
@galargh galargh changed the title feat: enable merge queue on the v-next branch ci: enable merge queue on the v-next branch Aug 13, 2024
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 13, 2024
@galargh galargh force-pushed the galargh/merge-queue branch from c2a86e0 to e460231 Compare August 13, 2024 13:00
@galargh galargh marked this pull request as ready for review August 13, 2024 13:45
@galargh galargh requested a review from alcuadrado August 13, 2024 13:45
@alcuadrado
Copy link
Member

Nice! This is way simpler than what I expected. I'll merge it so that I can add the settings to the repo.

@alcuadrado alcuadrado merged commit f140e2d into v-next Aug 13, 2024
53 checks passed
@alcuadrado alcuadrado deleted the galargh/merge-queue branch August 13, 2024 17:50
@alcuadrado
Copy link
Member

It should be enabled now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants