Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocha test plugin #5598

Merged
merged 9 commits into from
Aug 28, 2024
Merged

Mocha test plugin #5598

merged 9 commits into from
Aug 28, 2024

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Aug 14, 2024

closes #5586

Branches off of #5584 so that PR should be merged first

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 6:03am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7ee9f04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zoeyTM zoeyTM requested review from alcuadrado and galargh August 14, 2024 08:13
@zoeyTM zoeyTM added v-next A Hardhat v3 development task and removed status:triaging labels Aug 14, 2024
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from 655ea62 to fa61d86 Compare August 14, 2024 08:15
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from fa61d86 to 1f51f8d Compare August 14, 2024 08:20
galargh
galargh reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments, but not much beyond what we discussed around node test runner :)

v-next/example-project/test/mocha/other-mocha-test.ts Outdated Show resolved Hide resolved
v-next/hardhat-errors/src/descriptors.ts Outdated Show resolved Hide resolved
v-next/hardhat-mocha-test-runner/dist/src/index.d.ts Outdated Show resolved Hide resolved
v-next/hardhat-mocha-test-runner/node_modules/.bin/_mocha Outdated Show resolved Hide resolved
v-next/hardhat-mocha-test-runner/src/task-action.ts Outdated Show resolved Hide resolved
v-next/hardhat-mocha-test-runner/src/task-action.ts Outdated Show resolved Hide resolved
alcuadrado
alcuadrado requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. It requires a similar set of changes than the other plugin.

@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from 1f51f8d to dd9d352 Compare August 19, 2024 06:07
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from dd9d352 to 413d01e Compare August 19, 2024 06:19
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from 413d01e to 768a2a2 Compare August 19, 2024 06:28
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from cad3efa to 8c98257 Compare August 27, 2024 06:55
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from 8c98257 to c0393c7 Compare August 27, 2024 06:59
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from c0393c7 to 05fa63e Compare August 27, 2024 07:08
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from 05fa63e to 29c470e Compare August 27, 2024 07:10
@zoeyTM zoeyTM enabled auto-merge August 27, 2024 07:18
@zoeyTM zoeyTM disabled auto-merge August 27, 2024 07:18
@zoeyTM zoeyTM requested a review from alcuadrado August 27, 2024 07:18
@zoeyTM zoeyTM force-pushed the mocha-test-runner branch from 29c470e to 7ee9f04 Compare August 28, 2024 06:02
@github-actions GitHub Actions
Copy link
Contributor

hardhat

Total size of the bundle: 38M
Total number of dependencies (including transitive): 47

List of dependencies (sorted by size) 
36M	total
20M	esbuild
2.8M	@sentry/tracing
1.6M	undici
1.2M	@sentry/types
960K	node-addon-api
932K	@sentry/node
924K	@sentry/utils
912K	keccak
824K	zod
808K	@ignored/hardhat-vnext-core
652K	@ignored/hardhat-vnext-utils
592K	tsx
548K	@sentry/core
520K	fast-equals
448K	@noble/hashes
344K	@sentry/hub
320K	enquirer
296K	semver
244K	@scure/bip39
240K	ethereum-cryptography
196K	readable-stream
164K	@ignored/hardhat-vnext-errors
148K	@scure/base
132K	@noble/secp256k1
128K	get-tsconfig
92K	chalk
88K	tslib
88K	@sentry/minimal
76K	agent-base
72K	lru_map
68K	rfdc
68K	debug
64K	https-proxy-agent
60K	node-gyp-build
56K	@scure/bip32
48K	safe-buffer
48K	ansi-colors
48K	@ignored/hardhat-vnext-zod-utils
40K	resolve-pkg-maps
32K	string_decoder
32K	cookie
28K	util-deprecate
24K	strip-ansi
24K	inherits
24K	env-paths
24K	ansi-regex
20K	ms

@zoeyTM zoeyTM added this pull request to the merge queue Aug 28, 2024
Merged via the queue into v-next with commit f101294 Aug 28, 2024
126 checks passed
@zoeyTM zoeyTM deleted the mocha-test-runner branch August 28, 2024 06:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@galargh galargh galargh left review comments

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@zoeyTM zoeyTM

Labels
v-next A Hardhat v3 development task
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoeyTM @alcuadrado @galargh @kanej