Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring tasks for v-next #6032

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

antico5
Copy link
Contributor

@antico5 antico5 commented Dec 9, 2024

This PR addresses some minor refactorings:

  • Removing redundant v-next/hardhat/src/internal/cli/init/constants.ts
  • Rename cli help's helper files to match kebab-case
  • Rename cli/helpers to cli/help since it only contains helpers for the help task, to be consistent with the init task.

@antico5 antico5 requested a review from schaable December 9, 2024 16:41
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 8cee837

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 0:29am

@antico5 antico5 changed the title Minor refactoring tasks v next Minor refactoring tasks for v-next Dec 9, 2024
@antico5 antico5 changed the base branch from main to v-next December 9, 2024 16:41
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antico5 antico5 force-pushed the minor-refactoring-tasks-v-next branch from 000508b to 8cee837 Compare December 13, 2024 12:28
@antico5 antico5 enabled auto-merge December 13, 2024 12:28
@antico5 antico5 added this pull request to the merge queue Dec 13, 2024
Merged via the queue into v-next with commit 0e65cf8 Dec 13, 2024
45 checks passed
@antico5 antico5 deleted the minor-refactoring-tasks-v-next branch December 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants