Resolve references lazily #1228
Merged
+266
−272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only don't include extensions when recursion is not allowed in resolution.
ggiraldez
force-pushed
the
lazy-resolution
branch
from
de03aee to
0dad66e
Compare
…ol is pushed next This avoids a lot of extra work for the resolution when the identifier being resolved is a variable that has a type. Since the definition is found but then replace by the sequence `@typeof` and the type of the variable, which will never resolve. This path *is* used when resolving for members of the type of the variable.
ggiraldez
changed the title
OmarTawfik
reviewed
Feb 4, 2025
OmarTawfik
reviewed
Feb 4, 2025
OmarTawfik
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully reduces resolution time when not all references (eg. those in dependencies) need to be resolved, but requires the
BindingGraphto retain both theStackGraphand theResolver(with the database of partial path candidates and the partial paths arena).This PR also includes an optimization to the resolution algorithm. When selecting candidates to extend an already complete partial path, discard those that would immediately push a
@typeofsymbol (eg. through the path that replaces a variable by its type) since we know those will never resolve. This can halve the number of evaluated partial paths (ie. references that resolve to a variable/field definition) and provide a very significant performance gain in some cases.