[LLT-5312] Add more logging when read from tun failure happens #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jauler
force-pushed
the
LLT-5312_add_logging_when_read_from_tun_failure_happens
branch
from
f97c792 to
a6b3ebe
Compare
Jauler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During nightly tests on job 13830453 windows has failed to create wintun/wg-go adapter. And the test failed. After some investigation it seems like the tunnel is being destructed from within itself.
The only feasible place where this could happen seems to be here: https://github.com/NordSecurity/wireguard-go/blob/v0.0.2/device/send.go#L316, which is triggered by receiving error while reading from tunnel. In order to guide the investigation further, it would be nice to figure our exactly which error occurs, and thus this PR adds some more detailed logs.