print the error; fixes #60

src/batchless.rs

@@ -39,13 +39,20 @@ impl BatchlessJobManager {
 }
 
 impl BatchlessJobManager {
-    fn lookup(&mut self, processes: &[process::Process], want_pid: usize) -> Option<(usize, usize)> {
+    fn lookup(
+        &mut self,
+        processes: &[process::Process],
+        want_pid: usize,
+    ) -> Option<(usize, usize)> {
         let probe = self.cache.get(&want_pid);
         if probe.is_some() {
             return probe.copied();
         }
 
-        for process::Process { pid, ppid, session, .. } in processes {
+        for process::Process {
+            pid, ppid, session, ..
+        } in processes
+        {
             if *pid == want_pid {
                 let entry = (*session, *ppid);
                 self.cache.insert(want_pid, entry);

src/main.rs

@@ -55,7 +55,7 @@ fn main() {
     }
 }
 
-fn log(msg: &str) {
+fn log_cmderror(msg: &str) {
     // TODO (issue 52): Implement some sensible logging maybe
     eprintln!("SONAR ERROR: {:?}", msg);
 }

src/process.rs

@@ -27,7 +27,7 @@ pub fn get_process_information(jobs: &mut dyn jobs::JobManager) -> Result<Vec<Pr
         TIMEOUT_SECONDS,
     ) {
         Ok(out) => Ok(parse_ps_output(&out, need_process_tree)),
-        Err(e) => Err(e)
+        Err(e) => Err(e),
     }
 }
 
@@ -110,8 +110,7 @@ pub fn parsed_full_test_output() -> Vec<Process> {
     // Generated by PS_COMMAND_COMPLETE on lth's laptop, slightly edited to orphan #80199
     //"ps -e --no-header -o pid,user:22,pcpu,pmem,size,ppid,sess,comm"
     // pid user                pcpu pmen  size     ppid    sess command
-    let text =
-"      1 root                    0.0  0.0 21516       0       1 systemd
+    let text = "      1 root                    0.0  0.0 21516       0       1 systemd
       2 root                    0.0  0.0     0       0       0 kthreadd
       3 root                    0.0  0.0     0       2       0 rcu_gp
       4 root                    0.0  0.0     0       2       0 rcu_par_gp

src/ps.rs

@@ -4,7 +4,7 @@
 use crate::amd;
 use crate::command::CmdError;
 use crate::jobs;
-use crate::log;
+use crate::log_cmderror;
 use crate::nvidia;
 use crate::process;
 use crate::util::{three_places, time_iso8601};
@@ -171,7 +171,7 @@ fn add_gpu_info(
             }
         }
         Err(_) => {
-            log("GPU process listing failed");
+            log_cmderror("GPU process listing failed");
         }
     }
 }
@@ -221,8 +221,8 @@ pub fn create_snapshot(
     let mut user_by_pid: HashMap<usize, String> = HashMap::new();
 
     match process::get_process_information(jobs) {
-        Err(_e) => {
-            log("CPU process listing failed");
+        Err(_) => {
+            log_cmderror("CPU process listing failed");
             return;
         }
         Ok(ps_output) => {