Amd gpu support #49
Merged
Amd gpu support #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I try to rebase this on top of |
|
I'll have a look. |
|
Rebased patch tested on ML4 with AMD cards, seems to work OK. |
Closed
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses the output of rocm-smi to generate GPU usage data for AMD, as for NVIDIA. It's a bit of a hack but is reliable in my testing - I have a machine with two NVIDIA cards, and some test code that uses both of them.
I think that our nervousness about running nvidia-smi (see #44) is going to be even more acute for rocm-smi.
(The base rev here is not the tip of my work queue but the underlying main refactoring of ps.rs, #45, a little rebasing work will be required to land this if all the other patches land first.)