Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit 51 53 58 #59

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Submit 51 53 58 #59

merged 5 commits into from
Jun 23, 2023

Conversation

lars-t-hansen
Copy link
Collaborator

Patch stack fixing #51, #53, #58.

Lars T Hansen added 4 commits June 23, 2023 12:28
Fix #53 - Propagate errors from the command module + skeleton logging.
45718fe 
The current error propagation leaks the error code from the command
module up through the layers, even though the "get information" layer
need not run any subcommands.  This can be fixed later if we start
going directly to /proc for information.
Fix #51 - Handle more input from subprocess
fe4e13a
Fix #58 - Batchless jobs - synthesize job ID from process tree.
141ef91
fixup! Fix #58 - Batchless jobs - synthesize job ID from process tree.
49bd826
@lars-t-hansen lars-t-hansen requested a review from bast June 23, 2023 10:30
@bast bast merged commit 9d2d16b into NordicHPC:main Jun 23, 2023
@bast
Copy link
Member

bast commented Jun 23, 2023

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bast bast Awaiting requested review from bast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lars-t-hansen @bast