Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort() DFU can take very long when not yet connected #219

Closed
bobatsar opened this issue Feb 14, 2020 · 6 comments
Closed

abort() DFU can take very long when not yet connected #219

bobatsar opened this issue Feb 14, 2020 · 6 comments

Comments

@bobatsar
Copy link

DFU Bootloader version (please complete the following information):

  • SDK version: SDK 15.0
  • Bonding used: no
  • Library version: 1.10.0

Device information (please complete the following information):

  • Device: HTC U11 Life
  • OS: Android 9

Description
When calling abort() if a device was not yet connected it can take up to 20 s until the service gets stopped.

abort() while uploading a firmware return immediately.

@bobatsar bobatsar added the bug label Feb 14, 2020
@philips77
Copy link
Member

Yes, in the current implementation the abort only is executed when the library is suppose to do something. It checks that flag and aborts. But if a connection was requested, the library just waits for a callback, either with state connected or an error, before taking any action.

@bobatsar
Copy link
Author

Is there any way, that the callback is executed earlier?

@philips77 philips77 added enhancement and removed bug labels Feb 27, 2020
@philips77
Copy link
Member

Let's call it a feature request. Unfortunately, I have no time to implement it at the moment, so you'll have to wait. But as the priority for this is very low, I don't think we can fix it in 2020, unless I'm done with all other tasks. Sorry for that.

@philips77
Copy link
Member

Hi, I've started implementing fixing this issue. I'll release a version today.

philips77 added a commit that referenced this issue Jul 28, 2020
@philips77
Copy link
Member

Released in 1.11.0. Please, test if you have time.

@bobatsar
Copy link
Author

bobatsar commented Aug 4, 2020

@philips77 I just did a quick test and it seems to work. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants