-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abort() DFU can take very long when not yet connected #219
Comments
Yes, in the current implementation the abort only is executed when the library is suppose to do something. It checks that flag and aborts. But if a connection was requested, the library just waits for a callback, either with state connected or an error, before taking any action. |
Is there any way, that the callback is executed earlier? |
Let's call it a feature request. Unfortunately, I have no time to implement it at the moment, so you'll have to wait. But as the priority for this is very low, I don't think we can fix it in 2020, unless I'm done with all other tasks. Sorry for that. |
Hi, I've started implementing fixing this issue. I'll release a version today. |
Released in 1.11.0. Please, test if you have time. |
@philips77 I just did a quick test and it seems to work. Thanks for the fix. |
DFU Bootloader version (please complete the following information):
Device information (please complete the following information):
Description
When calling abort() if a device was not yet connected it can take up to 20 s until the service gets stopped.
abort() while uploading a firmware return immediately.
The text was updated successfully, but these errors were encountered: