Android 12 #313
Merged
Android 12 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for the PR! Did you test it on Android 12? Does the immutable flag work? PR looks great. |
|
I've tested on Android12 and also checked that Android9-11 still works |
|
Thank you. I'll check it tomorrow or on Wednesday, but looks good. |
|
Hey @philips77 did you get a chance to review this PR? |
|
Not yet :( Next week for sure! |
|
Any luck reviewing this PR? We've had our fork out in the wild for 2 weeks now with no issues reported |
|
I'm on sick leave from last week... I'll come to you when back to the office. |
This was referenced Oct 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Android 12 #312
mavenCentraland change the way thecom.jfrog.bintrayplugin was configured to get the project to buildFLAG_IMMUTABLEflag to allPendingIntents see https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability