Skip to content

Commit

Permalink
Fix problems with running scripts under Windows
Browse files Browse the repository at this point in the history
Work around an issue on Windows with running scripts using `env -S`
npm/cmd-shim#54
  • Loading branch information
datenreisender committed May 2, 2022
1 parent e5b1dfd commit 0e5a329
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 10 deletions.
12 changes: 9 additions & 3 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to
[Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 6.0.3 - 2022-05-02

### Fixed

- Problems with new scripts under Windows.

## 6.0.2 - 2022-04-28

### Changed
Expand Down Expand Up @@ -48,8 +54,8 @@ and this project adheres to
### Steps to upgrade when using this package

- The device-lib in launcher 3.11 crashes with shared@6, so you must bump the
`engines` field in `package.json` to require at least version `3.12` of the
launcher.
`engines` field in `package.json` to require at least version `3.11.1` of
the launcher.

- Because this version removed `nrfconnect-scripts`, all invocations of it
have to be replaced with direct invocations of the corresponding tools. So
Expand All @@ -63,7 +69,7 @@ and this project adheres to
"webpack": "webpack build --mode development",
"build": "webpack build",
"test": "jest",
"check": "run-p --silent --continue-on-error --print-label 'check:*'",
"check": "run-p --silent --continue-on-error --print-label check:*",
"check:lint": "eslint --color .",
"check:types": "check-for-typescript tsc --noEmit --pretty",
"check:license": "nrfconnect-license check",
Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pc-nrfconnect-shared",
"version": "6.0.2",
"version": "6.0.3",
"description": "Shared commodities for developing pc-nrfconnect-* packages",
"repository": {
"type": "git",
Expand All @@ -9,17 +9,17 @@
"author": "Nordic Semiconductor ASA",
"license": "ISC",
"bin": {
"nrfconnect-license": "./scripts/nrfconnect-license.ts",
"check-for-typescript": "./scripts/check-for-typescript.ts",
"nordic-publish": "./scripts/nordic-publish.ts"
"nrfconnect-license": "./scripts/nrfconnect-license.sh",
"check-for-typescript": "./scripts/check-for-typescript.sh",
"nordic-publish": "./scripts/nordic-publish.sh"
},
"main": "src",
"scripts": {
"test": "jest",
"check": "run-p --silent --continue-on-error --print-label 'check:*'",
"check": "run-p --silent --continue-on-error --print-label check:*",
"check:lint": "eslint --color .",
"check:types": "scripts/check-for-typescript.ts tsc --noEmit --pretty",
"check:license": "./scripts/nrfconnect-license.ts check"
"check:types": "ts-node --swc scripts/check-for-typescript.ts tsc --noEmit --pretty",
"check:license": "ts-node --swc scripts/nrfconnect-license.ts check"
},
"dependencies": {
"@babel/core": "7.17.5",
Expand Down
3 changes: 3 additions & 0 deletions scripts/check-for-typescript.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

ts-node --swc "$(dirname $0)/check-for-typescript.ts" "$@"
3 changes: 3 additions & 0 deletions scripts/nordic-publish.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

ts-node --swc "$(dirname $0)/nordic-publish.ts" "$@"
3 changes: 3 additions & 0 deletions scripts/nrfconnect-license.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env bash

ts-node --swc "$(dirname $0)/nrfconnect-license.ts" "$@"

0 comments on commit 0e5a329

Please sign in to comment.