Fix: wait for bootloader mode on apple silicon (#929)

NordicSemiconductor · Jun 11, 2024 · 6ee0700 · 6ee0700
1 parent f34d0a3
commit 6ee0700
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -7,6 +7,17 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 178.0.0 - 2024-06-11
+
+### Changed
+
+-   `isDeviceInDFUBootloader` now also expect nordic DFU Trait to be true
+
+### Fixed
+
+-   Wait for device `when='dfuBootLoaderMode'` will wait until nordic DFU Trait
+    is also present
+
 ## 177.0.0 - 2024-05-28
 
 ### Added

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "177.0.0",
+    "version": "178.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

diff --git a/src/Device/sdfuOperations.ts b/src/Device/sdfuOperations.ts
@@ -47,7 +47,8 @@ export const isDeviceInDFUBootloader = (device: Device) => {
         const { descriptor: d } = device.usb.device;
         return (
             d.idVendor === NORDIC_VENDOR_ID &&
-            d.idProduct === NORDIC_DFU_PRODUCT_ID
+            d.idProduct === NORDIC_DFU_PRODUCT_ID &&
+            !!device.traits.nordicDfu
         );
     }