Skip to content

Commit

Permalink
Merge pull request #908 from NordicSemiconductor/fix/confrm-close-reload
Browse files Browse the repository at this point in the history
Fix: confirmCloseDialog on reload clears launchers state allowing reload to work again
  • Loading branch information
kylebonnici authored Mar 8, 2024
2 parents 647be71 + c5bdf24 commit d5b2998
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ every new version is a new major version.
### Fixed

- `Group` will not collapse on click unless collapsible property is set
- `ConfirmCloseDialog` now cancels launcher's request to reload. Requires
engine version 4.4.1

## 166.0.0 - 2024-03-05

Expand Down
1 change: 1 addition & 0 deletions src/ConfirmBeforeClose/ConfirmCloseDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export default () => {
}
}}
onCancel={() => {
getCurrentWindow().emit('restart-cancelled');
dispatch(setShowCloseDialog(false));
confirmedDialogs.forEach(confirmedDialog =>
dispatch(addConfirmBeforeClose(confirmedDialog))
Expand Down

0 comments on commit d5b2998

Please sign in to comment.