Support specifying both PHP and JS code in code blocks #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
php-pegjs
requires specifying all code inside code blocks as PHP. However, for WordPress/gutenberg we want to use the same PEG in both PHP and JS code (see WordPress/gutenberg#1086).Accordingly, this PR adds the capability to specify both PHP and JS code in the same code block, using a syntax that is ignored by normal PEG.js, as follows:
This PR also fixes an instance of
void 0
being inserted into the generated PHP code. Elsewhere ingenerate-bytecode-php.js
this isnull
instead, so the same change has been made here.