fix: 🐛 Fix the TypeScript signature

✅ Closes: #134
NoriSte · May 13, 2020 · 126fea6 · 126fea6
1 parent ce796ce
commit 126fea6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/cypress/types/plugin.spec.ts b/cypress/types/plugin.spec.ts
@@ -77,3 +77,8 @@ cy.waitUntil<boolean>(() => true, {
 })
 cy.waitUntil<boolean>(() => true, { log: false })
 cy.waitUntil<boolean>(() => true, { customMessage: 'custom message' })
+
+cy.wrap('').waitUntil((subject) => subject.length)
+cy.wrap('').waitUntil<boolean>((subject) => !!subject.length)
+cy.wrap<string>('').waitUntil<boolean>((subject) => !!subject.length)
+cy.wrap<string>('').waitUntil((subject) => subject.length)
diff --git a/index.d.ts b/index.d.ts
@@ -21,8 +21,10 @@ interface WaitUntilOptions<Subject = any> {
 
 declare namespace Cypress {
   interface Chainable<Subject = any> {
-    waitUntil<Subject>(
-      checkFunction: () => Subject | Chainable<Subject> | Promise<Subject>,
+    waitUntil<ReturnType = any>(
+      checkFunction: (
+        subject: Subject | undefined
+      ) => ReturnType | Chainable<ReturnType> | Promise<ReturnType>,
       options?: WaitUntilOptions<Subject>
     ): Chainable<Subject>
   }