Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong casing on reference types causes typscript build issues #481

Closed
piccit opened this issue Jul 12, 2024 · 4 comments · Fixed by #482
Closed

wrong casing on reference types causes typscript build issues #481

piccit opened this issue Jul 12, 2024 · 4 comments · Fixed by #482

Comments

@piccit
Copy link

piccit commented Jul 12, 2024

I have an internal helper library that uses cypress-wait-until written in typescript. When trying to update to typescript 5.5 it fails to build due to Cannot find type definition file for 'Cypress' / "file name differs only in casing" referring to Cypress vs cypress. The capital C Cypress is coming from cypress-wait-until's index.d.ts and plugin.spec.ts. The actual cypress node module is all lowercase, so I believe these 2 references should be /// <reference types="cypress" /> instead of using a capital C

@NoriSte
Copy link
Owner

NoriSte commented Jul 16, 2024

@all-contributors please add @piccit for bug

Copy link
Contributor

@NoriSte

I've put up a pull request to add @piccit! 🎉

NoriSte added a commit that referenced this issue Jul 16, 2024
@NoriSte
Copy link
Owner

NoriSte commented Jul 16, 2024

Thank you for reporting it!! Let me know if the just-published 3.0.2 fixes it :)

@piccit
Copy link
Author

piccit commented Jul 29, 2024

Thank you for reporting it!! Let me know if the just-published 3.0.2 fixes it :)

Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants