Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper logging #53

Closed
seeu1 opened this issue Oct 28, 2019 · 5 comments · Fixed by #54
Closed

Add proper logging #53

seeu1 opened this issue Oct 28, 2019 · 5 comments · Fixed by #54
Labels

Comments

@seeu1
Copy link

seeu1 commented Oct 28, 2019

Today I ran a test using the waitUntil and it works perfectly, but logs a lot of ugly wait 200.
My idea (and I saw a lot of other plugins use it) is name the command to waitUntil and add an option for description (right side of the command).
in code: cy.waitUntil(() => something(), { description: "short description near command name" })
if a description was not supplied, just leave this part empty (no text).

For example:
before this change:
from

After this change:
to

NoriSte added a commit that referenced this issue Oct 30, 2019
The official documentation suggests to customize the use of Cypress.log
https://docs.cypress.io/api/cypress-api/cypress-log.html#Syntax

Closes: #53
@NoriSte
Copy link
Owner

NoriSte commented Oct 30, 2019

@seeu1 I've just released it, let me know it if works for you 😊

@seeu1
Copy link
Author

seeu1 commented Oct 30, 2019

@NoriSte Love it 🥇 just 3 little things:

  1. please add an option for no logging (log: false)
  2. please add an option for custom message (instead of just printing the options, customMessage 'page loaded')
  3. and the least important - the spinning animation on the left side in the cypress open window (when the command runs but was not done yet)

@NoriSte NoriSte reopened this Oct 31, 2019
NoriSte added a commit that referenced this issue Oct 31, 2019
@NoriSte
Copy link
Owner

NoriSte commented Oct 31, 2019

Hi @seeu1

  1. ✅ done
  2. ✅ done
  3. ❌ not possible at the moment because I'd add something like cypress-promise but there are a lot of limitations in using it

Please, take a look at the latest changes, if you like them I'll release it on NPM 😉

@seeu1
Copy link
Author

seeu1 commented Oct 31, 2019

@NoriSte Amazing! Thank you so much

@seeu1 seeu1 closed this as completed Oct 31, 2019
@NoriSte
Copy link
Owner

NoriSte commented Oct 31, 2019

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants