Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the timeout logic. #465

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Changing the timeout logic. #465

merged 1 commit into from
Jun 14, 2023

Commits on Jun 14, 2023

  1. fix: update the timeout logic to consider also the checkFunction dura… 

    …tion

Before this commit, the number of retries was calculated ignoring the checkFunction duration.

As a result, a 5s timeout with a 0.5s interval resulted in 10 retries.
If the checkFunction takes 10 seconds, 10 retries mean waiting for 100 seconds, violating the 5s timeout.

This commit fixes the problem by checking, after each checkFunction invocation, what is the elapsed time and stops retrying in case the timeout is over.

BREAKING CHANGE: The timeout is now respected even if checkFunction takes a long time. As a result,
you could face that your checkFunction runs less times.

fix NoriSte#464
    @NoriSte
    NoriSte committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    b6fc554 View commit details
    Browse the repository at this point in the history