Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TS definition for logger and updates script for running locally #66

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

sweir27
Copy link
Contributor

@sweir27 sweir27 commented Dec 5, 2019

👋 Hi there!

We've been happily using this library in our integration testing repository (thanks!).

After upgrading to the latest version to get the benefits of more verbose logging, I noticed that there was a TypeScript issue in the declaration file.

node_modules/cypress-wait-until/index.d.ts:13:13 - error TS7051: Parameter has a name but no type. Did you mean 'arg0: WaitUntilLog'?

13   logger?: (WaitUntilLog) => any;
               ~~~~~~~~~~~~

Found 1 error.

Following the Contributing instructions in the README, I also noticed/fixed an error in the cypress-run.js script.

@NoriSte NoriSte merged commit b4eb742 into NoriSte:master Dec 12, 2019
@NoriSte
Copy link
Owner

NoriSte commented Dec 12, 2019

@all-contributors please add @sweir27 for bug and code

@allcontributors
Copy link
Contributor

@NoriSte

I've put up a pull request to add @sweir27! 🎉

@NoriSte
Copy link
Owner

NoriSte commented Dec 12, 2019

Thank you so much @sweir27 and sorry for the long delay 😉 in minutes it should be on NPM, I'll check it out

@NoriSte
Copy link
Owner

NoriSte commented Dec 12, 2019

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sweir27
Copy link
Contributor Author

sweir27 commented Dec 12, 2019

@NoriSte Thank you! (And nice param rename 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants