Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mobile homework page #168

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: mobile homework page #168

wants to merge 5 commits into from

Conversation

laporchen
Copy link
Contributor

Updated #161

Light theme

Screenshot 2024-04-09 at 3 19 13 PM Screenshot 2024-04-09 at 3 16 52 PM

Dark theme

Screenshot 2024-04-09 at 3 16 58 PM Screenshot 2024-04-09 at 3 17 12 PM

Non-Admin

image

@laporchen laporchen requested a review from uier April 9, 2024 07:25
uier
uier reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@uier uier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing great mobile UI!

The changes look good to me, however, I'm thinking about if or not to place the ProblemInfoCard.vue under compomnents/Problem since only homework related component is using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uier uier uier left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laporchen @uier