Feat: add function to standardize uploaded csv in batch signup #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nfe with
|
| Latest commit: |
8753ad2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0d34216.nfe.pages.dev |
| Branch Preview URL: | https://feat-format-batch-sign-up.nfe.pages.dev |
uier
reviewed
Sep 12, 2024
There was a problem hiding this comment.
The changes about csv checking look good to me.
To make usernames Uppercase, please ensure other maintainers are awared of and agree with this approah.
Sorry I'm occupied with my MS thesis so I cannot catch up with your discussion on discord, please ask for someone else to approve this.
Also, it would be nice to add warning/description on UI about this standardization.
uier
reviewed
Sep 12, 2024
| @@ -48,12 +48,32 @@ const forceUpdate = ref(false); | |||
| const isProcessingSignup = ref(false); | |||
| const errorMsg = ref(""); | |||
| const previewCSV = ref<{ headers?: string[]; body?: string[][] }>({}); | |||
|
|
|||
| // no csv validation was handled | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just do a quick mapping on uploaded file.
Also need to do this in backend if we really want to handle this properly.