Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in unit conversion #122

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

ianmtaylor1
Copy link
Contributor

♻️ Current situation

A memory leak exists converting inches to millimeters. It is related to an issue created in OpenMQTTGateway: 1technophile/OpenMQTTGateway#1693

💡 Proposed solution

Avoid nesting calls to str_replace, to allow allocated memory to be properly freed.

⚙️ Release Notes

N/A

@NorthernMan54
Copy link
Owner

Just looked and this is an issue in the upstream repo - https://github.com/merbanan/rtl_433/blob/8950dc41823f0a34dda8a40789134413545e8b62/src/r_api.c#L733

Going to open this there as well

Give me a day or so, and will release this

Tks very much for your efforts on tracking this down

@ianmtaylor1
Copy link
Contributor Author

Thank you as well, I'm happy I'm able to contribute to this project that's been very useful for me.

@NorthernMan54 NorthernMan54 changed the base branch from master to Release-0.3.2 December 17, 2023 15:05
@NorthernMan54 NorthernMan54 merged commit b5428d2 into NorthernMan54:Release-0.3.2 Dec 17, 2023
2 checks passed
@ianmtaylor1 ianmtaylor1 deleted the memtrace branch December 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants