Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix - Sort Orders Import By Date Added Desc #288

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Hotfix - Sort Orders Import By Date Added Desc #288

merged 2 commits into from
Mar 28, 2019

Conversation

supercid
Copy link
Member

@supercid supercid commented Mar 28, 2019 •
edited
Loading

Description

The order import sorting might cause best sellers recos to be displayed with outdated purchases. This orders the import by the most recent buys.

Related Issue

Fixes #287

How Has This Been Tested?

Tested with new nosto prestashop account and all orders were successfully imported in the correct order.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request

@supercid supercid added the bug label Mar 28, 2019
@supercid supercid added this to the 3.6.3 milestone Mar 28, 2019
@supercid supercid self-assigned this Mar 28, 2019
@supercid supercid merged commit d2b14bc into master Mar 28, 2019
@supercid supercid deleted the hotfix/sort-orders-import branch March 28, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mridang mridang mridang approved these changes

@fairlane fairlane fairlane approved these changes

@olsi-qose olsi-qose olsi-qose approved these changes

Assignees

@supercid supercid

Labels
bug
Projects
None yet
Milestone
3.6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@supercid @mridang @fairlane @olsi-qose