Feature - Bump SDK to auto escape all product tagging #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercid
changed the title
mridang
reviewed
Apr 8, 2019
mridang
reviewed
Apr 8, 2019
fairlane
approved these changes
Apr 8, 2019
mridang
approved these changes
Apr 8, 2019
|
@mridang Couldn't find anything wrong. Also did some testing and seems to be working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps SDK and encode HTML characters that are present in product tagging.
Related Issue
Fixes #281
How Has This Been Tested?
Tested searching for a escaped script javascript tag on the search query and double encoding product attributes/search term. They are correctly being escaped.
Checklist: