Improve signature for types

Nosto · Jul 22, 2024 · 1d5f133 · 1d5f133
1 parent 05a47dc
commit 1d5f133
Show file tree

Hide file tree

Showing 8 changed files with 30 additions and 41 deletions.
diff --git a/spec/category.spec.tsx b/spec/category.spec.tsx
@@ -11,11 +11,9 @@ test("Category page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="categorypage-nosto-1" />
-        <NostoPlacement id="categorypage-nosto-2" />
-        <NostoCategory category="Rings" />
-      </>
+      <NostoPlacement id="categorypage-nosto-1" />
+      <NostoPlacement id="categorypage-nosto-2" />
+      <NostoCategory category="Rings" />
     </NostoProvider>
   )
 

diff --git a/spec/checkout.spec.tsx b/spec/checkout.spec.tsx
@@ -11,12 +11,10 @@ test("Checkout page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="cartpage-nosto-1" />
-        <NostoPlacement id="cartpage-nosto-2" />
-        <NostoPlacement id="cartpage-nosto-3" />
-        <NostoCheckout />
-      </>
+      <NostoPlacement id="cartpage-nosto-1" />
+      <NostoPlacement id="cartpage-nosto-2" />
+      <NostoPlacement id="cartpage-nosto-3" />
+      <NostoCheckout />
     </NostoProvider>
   )
 

diff --git a/spec/fohofo.spec.tsx b/spec/fohofo.spec.tsx
@@ -11,11 +11,9 @@ test("404 page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="notfound-nosto-1" />
-        <NostoPlacement id="notfound-nosto-2" />
-        <Nosto404 />
-      </>
+      <NostoPlacement id="notfound-nosto-1" />
+      <NostoPlacement id="notfound-nosto-2" />
+      <Nosto404 />
     </NostoProvider>
   )
 

diff --git a/spec/home.spec.tsx b/spec/home.spec.tsx
@@ -11,12 +11,10 @@ test("Home page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="frontpage-nosto-1" />
-        <NostoPlacement id="frontpage-nosto-3" />
-        <NostoPlacement id="frontpage-nosto-4" />
-        <NostoHome />
-      </>
+      <NostoPlacement id="frontpage-nosto-1" />
+      <NostoPlacement id="frontpage-nosto-3" />
+      <NostoPlacement id="frontpage-nosto-4" />
+      <NostoHome />
     </NostoProvider>
   )
 

diff --git a/spec/other.spec.tsx b/spec/other.spec.tsx
@@ -11,13 +11,11 @@ test("Other page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="cartpage-nosto-1" />
-        <NostoPlacement id="categorypage-nosto-1" />
-        <NostoPlacement id="productpage-nosto-1" />
-        <NostoPlacement id="productpage-nosto-2" />
-        <NostoOther />
-      </>
+      <NostoPlacement id="cartpage-nosto-1" />
+      <NostoPlacement id="categorypage-nosto-1" />
+      <NostoPlacement id="productpage-nosto-1" />
+      <NostoPlacement id="productpage-nosto-2" />
+      <NostoOther />
     </NostoProvider>
   )
 

diff --git a/spec/product.spec.tsx b/spec/product.spec.tsx
@@ -11,12 +11,10 @@ test("Product page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="productpage-nosto-1" />
-        <NostoPlacement id="productpage-nosto-2" />
-        <NostoPlacement id="productpage-nosto-3" />
-        <NostoProduct product="7078777258043" />
-      </>
+      <NostoPlacement id="productpage-nosto-1" />
+      <NostoPlacement id="productpage-nosto-2" />
+      <NostoPlacement id="productpage-nosto-3" />
+      <NostoProduct product="7078777258043" />
     </NostoProvider>
   )
 

diff --git a/spec/search.spec.tsx b/spec/search.spec.tsx
@@ -11,11 +11,9 @@ test("Search page render", async () => {
       account="shopify-11368366139"
       recommendationComponent={<RecommendationComponent />}
     >
-      <>
-        <NostoPlacement id="searchpage-nosto-1" />
-        <NostoPlacement id="searchpage-nosto-2" />
-        <NostoSearch query="" />
-      </>
+      <NostoPlacement id="searchpage-nosto-1" />
+      <NostoPlacement id="searchpage-nosto-2" />
+      <NostoSearch query="" />
     </NostoProvider>
   )
 

diff --git a/src/components/NostoProvider.tsx b/src/components/NostoProvider.tsx
@@ -18,7 +18,10 @@ export interface NostoProviderProps {
    * Indicates an url of a server
    */
   host?: string
-  children: React.ReactElement
+  /**
+   * children
+   */
+  children: React.ReactElement | React.ReactElement[]
   /**
    * Indicates if merchant uses multiple currencies
    */