Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align prop types #130

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Align prop types #130

merged 1 commit into from
Sep 3, 2024

Conversation

timowestnosto
Copy link
Contributor

Makes sure that NostoSession & NostoOrder snake case / camelCase aligned prop fields are declared in the same way

/**
* @group Hooks
*/
export type NostoSessionProps = {
cart?: Cart
customer?: Customer
cart?: CartSnakeCase | ToCamelCase<CartSnakeCase>
Copy link
Contributor Author

@timowestnosto timowestnosto Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inlined, since non exported types are not visible to typedoc

@timowestnosto timowestnosto merged commit c8faaa8 into master Sep 3, 2024
1 check passed
@timowestnosto timowestnosto deleted the align-prop-types branch September 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants