Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalise router dom deps #254

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

manikandan-ravikumar
Copy link
Contributor

@manikandan-ravikumar manikandan-ravikumar commented Dec 23, 2024

react-router-dom deps needs to be externalized to avoid react being bundled into the output
#247

BTW, the nosto-react library includes the following deps

── @nosto/nosto-js@1.0.9
├── @testing-library/jest-dom@6.6.3
├── @testing-library/react@16.1.0
├── @testing-library/user-event@14.5.2
├── @types/react-dom@18.3.1
├── @types/react@18.3.12
├── @types/user-event@4.1.3
├── @vitejs/plugin-react@4.3.4
├── eslint-plugin-promise@7.2.1
├── eslint-plugin-react@7.37.2
├── eslint@9.17.0
├── prettier@3.4.2
├── react-dom@18.3.1
├── react-router-dom@7.0.2
├── react-router@7.0.2
├── react@18.3.1
├── rimraf@6.0.1
├── typedoc@0.27.5
├── typescript-eslint@8.18.1
├── typescript@5.7.2
├── vite-plugin-dts@4.3.0
├── vite@6.0.3
└── vitest@2.1.8

@manikandan-ravikumar manikandan-ravikumar merged commit 58b781b into master Dec 23, 2024
1 check passed
@manikandan-ravikumar manikandan-ravikumar deleted the externalize-react-router-dom branch December 23, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants