Add support for onsite content injection #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,14 +19,16 @@ function RecommendationComponentWrapper(props: { | |||
| }) | |||
| } | |||
|
|
|||
| function injectPlacements(data: Record<string, unknown>) { | |||
| nostojs(api => api.placements.injectCampaigns(data as Parameters<API['placements']['injectCampaigns']>[0])) | |||
There was a problem hiding this comment.
The type assertation looks a bit hairy but I'm unsure whether we have better options here
There was a problem hiding this comment.
you are right, but the fixes would be in this order
- fix in client script (alignment between Session API Action Response & placement types)
- update to nosto-js
- update to nosto-react
nosto-mikpou
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.