Remove tagging and align API types #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timowestnosto
commented
Jun 18, 2024
| @@ -39,14 +39,13 @@ export default function NostoProduct(props: { | |||
| useNostoApi( | |||
| async (api) => { | |||
| const data = await api.defaultSession() | |||
| .viewProduct(tagging?.productId ?? product) | |||
| .viewProduct(tagging ?? product) | |||
There was a problem hiding this comment.
this will supply the full product tagging first and then fallback to productId
timowestnosto
commented
Jun 18, 2024
| @@ -13,8 +13,8 @@ import { useDeepCompareEffect } from "../utils/hooks" | |||
| * | |||
| * @group Essential Functions | |||
| */ | |||
| export default function NostoSession(props: { cart: Cart; customer: Customer }) { | |||
| const { cart, customer } = props | |||
| export default function NostoSession(props?: { cart?: Cart; customer?: Customer }) { | |||
There was a problem hiding this comment.
makes both cart and customer optional
timowestnosto
force-pushed
the
tagging-removal
branch
from
ab3894b to
1ee971a
Compare
timowestnosto
force-pushed
the
tagging-removal
branch
from
1ee971a to
7a3c29d
Compare
aiste-tamo
approved these changes
Jun 19, 2024
rokbar-nosto
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.