fix: do not crash on routing problem #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfmerijn
approved these changes
Jan 11, 2024
keeama13
pushed a commit
that referenced
this pull request
Jan 11, 2024
64knl
added a commit
that referenced
this pull request
Jan 11, 2024
* fix: add nullable (#163) * feat: set null for searchitem (#166) * fix: fallback to null for SearchItem * style: formatting * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * fix: redirect after cms user save succes (#171) * fix: autoload policies (#172) * fix: autoload policies * chore: remove autoloading policy from service provider * chore: update intervention/image requirement from ^2.7 to ^3.0 (#173) Updates the requirements on [intervention/image](https://github.com/Intervention/image) to permit the latest version. - [Commits](Intervention/image@2.7.0...3.0.1) --- updated-dependencies: - dependency-name: intervention/image dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: René <rene@64k.nl> * feat: model select (#104) * feat: select model * feat: display now working + modelselector * fix: display id * fix: possible null reference removed * feat: minor changes * feat: small fixes * feat: return key value pair from model * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * fix: image resize (work in progress) (#174) * fix: image resize (work in progress) * style: formatting * fix: scaleDown * fix: rename rights col in cms config table (#177) * fix: rename rights col in cms config table * style: formatting --------- Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl> * feat!: Childtable structure (#175) * feat!: fetch childtable values as array * fix: fetch all rows * fix: pretend to be a contentblock anyway * fix: create table error (#178) * feat: decrease architecture requirement for insights (#183) * fix: CMS users cannot be created as sub is not default null (#182) * fix: CMS users cannot be created as sub is not default null * fix: move to new migration * fix: rename migration to proper php * fix: do not crash on routing error (#181) * style: formatting * feat: add release-it package * fix: do not automatically create github release --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: M.A. Peene <maarten@notfound.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com> Co-authored-by: thessakockelkorn <70509512+thessakockelkorn@users.noreply.github.com> Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>
64knl
added a commit
that referenced
this pull request
Jan 11, 2024
* fix: add nullable (#163) * feat: set null for searchitem (#166) * fix: fallback to null for SearchItem * style: formatting * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * fix: redirect after cms user save succes (#171) * fix: autoload policies (#172) * fix: autoload policies * chore: remove autoloading policy from service provider * chore: update intervention/image requirement from ^2.7 to ^3.0 (#173) Updates the requirements on [intervention/image](https://github.com/Intervention/image) to permit the latest version. - [Commits](Intervention/image@2.7.0...3.0.1) --- updated-dependencies: - dependency-name: intervention/image dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: René <rene@64k.nl> * feat: model select (#104) * feat: select model * feat: display now working + modelselector * fix: display id * fix: possible null reference removed * feat: minor changes * feat: small fixes * feat: return key value pair from model * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * fix: image resize (work in progress) (#174) * fix: image resize (work in progress) * style: formatting * fix: scaleDown * fix: rename rights col in cms config table (#177) * fix: rename rights col in cms config table * style: formatting --------- Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl> * feat!: Childtable structure (#175) * feat!: fetch childtable values as array * fix: fetch all rows * fix: pretend to be a contentblock anyway * fix: create table error (#178) * feat: decrease architecture requirement for insights (#183) * fix: CMS users cannot be created as sub is not default null (#182) * fix: CMS users cannot be created as sub is not default null * fix: move to new migration * fix: rename migration to proper php * fix: do not crash on routing error (#181) * style: formatting * feat: add release-it package * fix: do not automatically create github release --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: M.A. Peene <maarten@notfound.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com> Co-authored-by: thessakockelkorn <70509512+thessakockelkorn@users.noreply.github.com> Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the dd() created a crash when the router could not find any pages. Now we'll just log the error. This way the CMS still works, and cli options are still running.