Merge pull request #579 from NotionX/fix/move-react-pdf-to-optional

NotionX · Nov 7, 2024 · 4611def · 4611def
2 parents 8c1cada + c78ead6
commit 4611def
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 9 deletions.
diff --git a/packages/react-notion-x/package.json b/packages/react-notion-x/package.json
@@ -65,8 +65,7 @@
     "react-hotkeys-hook": "^4.5.1",
     "react-image": "^4.0.3",
     "react-lazy-images": "^1.1.0",
-    "react-modal": "^3.14.3",
-    "react-pdf": "^9.1.1"
+    "react-modal": "^3.14.3"
   },
   "devDependencies": {
     "@types/lodash.throttle": "^4.1.6",
@@ -76,10 +75,14 @@
     "clipboard-copy": "^4.0.1",
     "date-fns": "^4.1.0",
     "format-number": "^3.0.0",
-    "lodash.throttle": "^4.1.1"
+    "lodash.throttle": "^4.1.1",
+    "react-pdf": "^9.1.1"
   },
   "peerDependencies": {
     "react": ">=18",
     "react-dom": ">=18"
+  },
+  "optionalDependencies": {
+    "react-pdf": "^9.1.1"
   }
 }
diff --git a/packages/react-notion-x/tsup.config.ts b/packages/react-notion-x/tsup.config.ts
@@ -17,5 +17,6 @@ export default defineConfig({
   shims: false,
   dts: true,
   minify: false,
-  sourcemap: true
+  sourcemap: true,
+  external: ['react-pdf']
 })
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml