Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are no longer rendering. Looks like the image file format has been changed by Notion #428

Open
pbteja1998 opened this issue Jan 31, 2023 · 8 comments

Comments

@pbteja1998
Copy link
Contributor

pbteja1998 commented Jan 31, 2023

Description

Now, image signed URLs are starting with files.notion.so for some reason and that case is not being handled by the defaultMapImageUrl. Because of this, images are no longer rendering correctly.

Check the below notion page for an example.

Notion Test Page ID

39192dc8661e4776a91cfa5eb37c9499

@james-freec
Copy link

I have the same problem, any one know how it fix?

@normdoow
Copy link
Collaborator

normdoow commented Feb 4, 2023

Yeah, I'm seeing this in some pages as well. But not all of them. May just be on new workspaces or something.

@transitive-bullshit
Copy link
Member

If any of you find a fix, please let us know.

@normdoow
Copy link
Collaborator

normdoow commented Feb 4, 2023

If any of you find a fix, please let us know.

Quick fix I found is using the source from the image block instead of the signed_url
image
But the signed url is needed because it doesn't expire right?

@transitive-bullshit
Copy link
Member

Signed URLs expire; maybe we can just use the source directly now? That would be amazing

@normdoow
Copy link
Collaborator

normdoow commented Feb 4, 2023

Hot fix: #430

@normdoow
Copy link
Collaborator

normdoow commented Feb 4, 2023

We will watch this to see how the hot fix performs in other scenarios. Once we learn more about the new notion source we can make a better solution.

@pbteja1998
Copy link
Contributor Author

Looks like now even the audio files have signed URLs starting with file.notion.so

Related: #441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants